fix: include pre-built extension dist so Chrome can load it#90
Closed
Astro-Han wants to merge 1 commit intojackwener:mainfrom
Closed
fix: include pre-built extension dist so Chrome can load it#90Astro-Han wants to merge 1 commit intojackwener:mainfrom
Astro-Han wants to merge 1 commit intojackwener:mainfrom
Conversation
The extension manifest.json references dist/background.js, but both the root .gitignore and extension/.gitignore excluded dist/, so the built file was never shipped in the repo or npm package. - Change root .gitignore from `dist/` to `/dist/` (root-only) - Remove `dist/` from extension/.gitignore - Commit the built extension/dist/background.js - Track extension/pnpm-lock.yaml for reproducible builds Fixes jackwener#88
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.gitignore(dist/) andextension/.gitignore(dist/) excludedextension/dist/background.js, butmanifest.jsonreferences it as the service worker — Chrome fails to load the extension.gitignorefromdist/to/dist/so it only ignores the root dist directorydist/fromextension/.gitignoreand commit the pre-builtextension/dist/background.jsextension/pnpm-lock.yamlfor reproducible buildsFixes #88
Test plan
extension/as unpacked extension in Chrome — should load without errorscd extension && pnpm build— verifydist/background.jsis regenerated and matches the committed version